Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A couple of small changes to internal node labelling #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jergosh
Copy link

@jergosh jergosh commented Sep 29, 2020

Hi Asif,
I had a go at fixing two small issues with labelling internal nodes I've encountered while running tdg09 on two fairly messy trees with a lot of group switches. I first noticed that tree labelling was crashing if the name of a group was longer than two characters and added a simple check for this.

This helped with one tree but labelling still crashed on the other. I think the issue was caused by parent-child node pairs that were both group switch ("_GS") nodes. In such cases, children nodes are labelled first but this was failing as the labels are set based on the group of the parent (which is at that point unlabelled). I think simply iterating over unknownNodes in reverse ensures the right order but I haven't tested this change extensively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant