Taplo CLI doesn't validate schemas if using schema catalog and cache and cache is existed

[hituzi-no-sippo]

Taplo CLI doesn't validate schemas if using schema catalog (--default-schema-catalogs, --schema-catalog <SCHEMA_CATALOG>) and --cach-path and Taplo cache is existed.

If use schema instead of schema catalog, that is, if using --schema <SCHEMA> and --cach-path and Taplo cache is existed, Taplo CLI validates schemas.

reproduce.sh

#!/usr/bin/env bash

wget --quiet --output-document taplo.gz https://github.com/tamasfe/taplo/releases/download/0.8.1/taplo-linux-x86_64.gz
gzip --decompress taplo.gz
chmod +x ./taplo
./taplo --version

declare toml_file='release-plz.toml'
echo -e '[[package]]\nname = 1' > "$toml_file"

set -x
./taplo lint --cache-path ./ --default-schema-catalogs "$toml_file"
ls

./taplo lint --cache-path ./ --default-schema-catalogs "$toml_file"
./taplo lint --cache-path ./ --schema-catalog https://www.schemastore.org/api/json/catalog.json "$toml_file"
./taplo lint --cache-path ./ --schema https://raw.githubusercontent.com/MarcoIeni/release-plz/main/.schema/latest.json "$toml_file"

Result

$ bash reproduce.sh
taplo 0.8.1
+ ./taplo lint --cache-path ./ --default-schema-catalogs release-plz.toml
INFO taplo:lint_files:collect_files: found files total=1 excluded=0 cwd="/home/hituzi_no_sippo/taplo_schema"
error: 1 is not of type "string"
┌─ /home/hituzi_no_sippo/taplo_schema/release-plz.toml:2:8
│
2 │ name = 1
│        ^ 1 is not of type "string"

ERROR taplo:lint_files: invalid file error=schema validation failed path="/home/hituzi_no_sippo/taplo_schema/release-plz.toml"
ERROR operation failed error=some files were not valid
+ ls
5b16e32f1334ff5b75ab387d99f1de40eeea4924  f6c331111c3dbf4da601b1da5a14bb49b3f362f0  release-plz.toml  reproduce.sh  taplo
+ ./taplo lint --cache-path ./ --default-schema-catalogs release-plz.toml
INFO taplo:lint_files:collect_files: found files total=1 excluded=0 cwd="/home/hituzi_no_sippo/taplo_schema"
+ ./taplo lint --cache-path ./ --schema-catalog https://www.schemastore.org/api/json/catalog.json release-plz.toml
INFO taplo:lint_files:collect_files: found files total=1 excluded=0 cwd="/home/hituzi_no_sippo/taplo_schema"
+ ./taplo lint --cache-path ./ --schema https://raw.githubusercontent.com/MarcoIeni/release-plz/main/.schema/latest.json release-plz.toml
INFO taplo:lint_files:collect_files: found files total=1 excluded=0 cwd="/home/hituzi_no_sippo/taplo_schema"
error: 1 is not of type "string"
┌─ /home/hituzi_no_sippo/taplo_schema/release-plz.toml:2:8
│
2 │ name = 1
│        ^ 1 is not of type "string"

ERROR taplo:lint_files: invalid file error=schema validation failed path="/home/hituzi_no_sippo/taplo_schema/release-plz.toml"
ERROR operation failed error=some files were not valid
$

System

• OS Ubuntu 20.04 LTS (WSL2)
• Version: taplo 0.8.1

Thanks.

[ia0]

Thanks for the bug report! I can reproduce. This looks indeed like a cache-related bug. It will need some investigation.

[ia0]

After investigation, the problem was that before being used, the index was transformed, such that the pattern was **/release-plz.toml instead of release-plz.toml. But this transformation was not saved to the cache and was not applied neither when loading from the cache, and thus no schema was found for the file.

[ia0]

You can install the latest version with cargo install taplo-cli --git=https://github.com/tamasfe/taplo.git --features=lsp.

[hituzi-no-sippo]

You can install the latest version with cargo install taplo-cli --git=https://github.com/tamasfe/taplo.git --features=lsp.

I've checked.
Thanks.