Add inverted-colors variant
#11693
Merged
Add inverted-colors variant
#11693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinMalfait
force-pushed
the
inverted-colors
branch
from
b6fd78e to
20480d9
Compare
lukewarlow
force-pushed
the
inverted-colors
branch
from
20480d9 to
28e9c00
Compare
RobinMalfait
force-pushed
the
inverted-colors
branch
from
28e9c00 to
dd221bc
Compare
|
Hey! You might have noticed that I forced pushed to this branch. The reason is because the PR now uses The code is ported as-is, so no API changes of your feature happened while moving it to the new codebase. I also made sure to add you as a co-author because you still deserve all the credit 💪 |
lukewarlow
force-pushed
the
inverted-colors
branch
2 times, most recently
from
bda1052 to
6d74187
Compare
philipp-spiess
force-pushed
the
inverted-colors
branch
from
6d74187 to
07bc3b0
Compare
philipp-spiess
force-pushed
the
inverted-colors
branch
from
07bc3b0 to
a10213c
Compare
philipp-spiess
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a variant for the
inverted-colorsmedia query.This has been supported in Safari for a while. I'm also implementing support in Chrome atm.
I've decided to only add the inverted-colors: inverted variant because the
nonestate isn't really useful.