Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: LTLに非掲載のパブリックノートを作成可能にする #5

Open
wants to merge 20 commits into
base: develop
Choose a base branch
from

Conversation

tai-cha
Copy link
Owner

@tai-cha tai-cha commented Dec 25, 2024

What

cherry-picked from nadesskey#58

Why

LTL重視サーバーでも連合ユーザーと不自由なくやり取りするため

懸念点

フラグの持ち方を大胆にも公開範囲で制御したためサードパーティークライアントが壊れるかも
→ 解消済み

misskey-dev/misskeyに上げないの?

→ 公開範囲が増えるのは混乱のもとでもあるかもしれないので様子見

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@tai-cha tai-cha changed the base branch from develop to fix/chart_is_suspended December 25, 2024 20:01
@tai-cha tai-cha changed the base branch from fix/chart_is_suspended to develop December 25, 2024 20:01
Copy link

github-actions bot commented Dec 25, 2024

このPRによるapi.jsonの差分

差分はこちら
--- base
+++ head
@@ -59387,6 +59387,7 @@
                     "type": "string",
                     "enum": [
                       "public",
+                      "public_non_ltl",
                       "home",
                       "followers",
                       "specified"
@@ -80038,6 +80039,9 @@
               "string",
               "null"
             ]
+          },
+          "dontShowOnLtl": {
+            "type": "boolean"
           }
         },
         "required": [
@@ -80052,7 +80056,8 @@
           "reactions",
           "reactionCount",
           "renoteCount",
-          "repliesCount"
+          "repliesCount",
+          "dontShowOnLtl"
         ]
       },
       "NoteReaction": {

Get diff files from Workflow Page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants