Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[non merge] focalorus.io用に開発したロール別お知らせのPR #4

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

tai-cha
Copy link
Owner

@tai-cha tai-cha commented Jul 22, 2024

What

ロール別お知らせを作った
cherry-picked from shiroha-a#4 , shiroha-a#5

Why

なんかロールを付けてる人にだけお知らせを送りたいことがあるみたい

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

Copy link

Thank you for sending us a great Pull Request! 👍
Please regenerate misskey-js type definitions! 🙏

example:

pnpm run build-misskey-js-with-types

Copy link

このPRによるapi.jsonの差分

差分はこちら
--- base
+++ head
@@ -3181,6 +3181,21 @@
                     ],
                     "format": "misskey:id",
                     "default": null
+                  },
+                  "isRoleSpecified": {
+                    "type": "boolean",
+                    "default": false
+                  },
+                  "roleIds": {
+                    "type": [
+                      "array",
+                      "null"
+                    ],
+                    "items": {
+                      "type": "string",
+                      "format": "misskey:id"
+                    },
+                    "default": null
                   }
                 },
                 "required": [
@@ -3594,6 +3609,28 @@
                           "null"
                         ]
                       },
+                      "isRoleSpecified": {
+                        "type": "boolean"
+                      },
+                      "roles": {
+                        "type": "array",
+                        "items": {
+                          "type": "object",
+                          "properties": {
+                            "id": {
+                              "type": "string",
+                              "format": "id"
+                            },
+                            "name": {
+                              "type": "string"
+                            }
+                          },
+                          "required": [
+                            "id",
+                            "name"
+                          ]
+                        }
+                      },
                       "reads": {
                         "type": "number"
                       }
@@ -3605,6 +3642,8 @@
                       "text",
                       "title",
                       "imageUrl",
+                      "isRoleSpecified",
+                      "roles",
                       "reads"
                     ]
                   }
@@ -3791,6 +3830,16 @@
                   },
                   "isActive": {
                     "type": "boolean"
+                  },
+                  "isRoleSpecified": {
+                    "type": "boolean"
+                  },
+                  "roleIds": {
+                    "type": "array",
+                    "items": {
+                      "type": "string",
+                      "format": "misskey:id"
+                    }
                   }
                 },
                 "required": [
@@ -77606,6 +77655,9 @@
           "forYou": {
             "type": "boolean"
           },
+          "forYourRoles": {
+            "type": "boolean"
+          },
           "isRead": {
             "type": "boolean"
           }
@@ -77621,7 +77673,8 @@
           "display",
           "needConfirmationToRead",
           "silence",
-          "forYou"
+          "forYou",
+          "forYourRoles"
         ]
       },
       "App": {

Get diff files from Workflow Page

@tai-cha tai-cha marked this pull request as draft July 22, 2024 16:22
tai-cha pushed a commit that referenced this pull request Jul 31, 2024
feat: ロールに応じたお知らせ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant