Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(module-index-client): Catch 404 errors on get requests in module index client #5558

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(module-index-client): Catch 404 errors on get requests in module index client #5558

wants to merge 1 commit into from

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Feb 26, 2025

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 26, 2025 •
edited
Loading

Dependency Review

✅ No vulnerabilities or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@stack72 stack72 force-pushed the catch-module-index-clients branch from ce3a73c to c9e70a5 Compare February 26, 2025 18:11
fnichol
fnichol approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@fnichol fnichol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done and not even as much work as I was expecting. I forgot about the error_for_status method and how that worked which really helps to deal with all remaining errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fnichol fnichol fnichol approved these changes

@nickgerace nickgerace nickgerace approved these changes

@zacharyhamm zacharyhamm Awaiting requested review from zacharyhamm

@britmyerss britmyerss Awaiting requested review from britmyerss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stack72 @fnichol @nickgerace