build: remove requirement file #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahnu
reviewed
Jan 3, 2020
noahnu
reviewed
Jan 3, 2020
setup.py
Outdated
| setup_requires = ["setuptools_scm"] | ||
| install_requires = ["typing_extensions>=3.6"] | ||
| dev_requires = [ | ||
| "black==19.10b0", |
There was a problem hiding this comment.
The issue with this pinning is that we don't have an easy way to update it. Our pip-tools command had an update flag.
There was a problem hiding this comment.
Was doing some reading https://snarky.ca/clarifying-pep-518/
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 16 16
Lines 693 693
=====================================
Hits 693 693 |
iamogbz
commented
Jan 4, 2020
| ctx.run(f"python -m piptools compile {source} {' '.join(args)}", pty=True) | ||
| ctx.run( | ||
| "echo '-e .[dev]' | python -m piptools compile " | ||
| f"{' '.join(args)} - -qo- | sed '/^-e / d' > {dest}", |
There was a problem hiding this comment.
Workaround from jazzband/pip-tools#908
noahnu
reviewed
Jan 4, 2020
script/bootstrap
Outdated
| $VENV/bin/python -m python_githooks | ||
|
|
||
| . $VENV/bin/activate | ||
| pip install -U pip --no-cache-dir |
noahnu
approved these changes
Jan 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes duplication and fragmentation of package dependencies in
requirements.txtandsetup.pyfileRelated Issues
N/A
Checklist
Additional Comments