Fix interface of Raw nodes to make them extendable again #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
👋 phase/new
JounQin
approved these changes
Sep 12, 2022
wooorm
reviewed
Sep 12, 2022
| @@ -1,10 +1,9 @@ | |||
| import type {Literal} from 'hast' | |||
|
|
|||
| export type Raw = { | |||
| export interface Raw extends Literal { | |||
There was a problem hiding this comment.
Please check your change locally, as I believe npm test will overwrite your changes. To keep them, include the needed xo ignore.
For why, see https://github.com/xojs/xo/releases/tag/v0.52.0.
There was a problem hiding this comment.
I see now, thanks. I did run npm test, but expected it to cause the script to fail and didn't think to check to see if it overwrote the files. I've added back the eslint-diable/eslint-enable block.
wooorm
changed the title
ChristianMurphy
approved these changes
Sep 12, 2022
wooorm
approved these changes
Sep 13, 2022
wooorm
changed the title
This comment has been minimized.
This comment has been minimized.
|
Released in 12.2.2! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
Resolves #65.
This PR expands the
eslint-ignoreblock introduced in d97bcbd to include theRawinterface to make it compatible with other declarations of theRawtype in other packages.