Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch AWS_SSO_SESSION_EXPIRATION to RFC3339 #870

Merged
merged 1 commit into from
Jun 4, 2024
Merged

switch AWS_SSO_SESSION_EXPIRATION to RFC3339 #870

merged 1 commit into from
Jun 4, 2024

Conversation

synfinatic
Copy link
Owner

Fixes: #837

@synfinatic synfinatic force-pushed the RFC3339 branch 13 times, most recently from fad6839 to c4d8a14 Compare June 4, 2024 18:42
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.13%. Comparing base (fbee93d) to head (8eae16e).
Report is 40 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #870      +/-   ##
==========================================
- Coverage   80.32%   80.13%   -0.19%     
==========================================
  Files          37       38       +1     
  Lines        3405     3427      +22     
==========================================
+ Hits         2735     2746      +11     
- Misses        595      606      +11     
  Partials       75       75              
Flag Coverage Δ
unittests 80.13% <88.89%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/ecs/http.go 100.00% <100.00%> (ø)
internal/storage/storage.go 94.23% <87.50%> (-0.21%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb95df2...8eae16e. Read the comment docs.

- Standardize all the code to express the Expire time
in RFC3339.
- ExpireISO8601 -> ExpireString

Fixes: #837
@synfinatic synfinatic added this to the 1.16.0 milestone Jun 4, 2024
@synfinatic synfinatic merged commit d7373f3 into main Jun 4, 2024
7 of 8 checks passed
@synfinatic synfinatic deleted the RFC3339 branch June 4, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS_SSO_SESSION_DURATION should use RFC3339 format
1 participant