Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoConfigCheck now honors AWS_CONFIG_FILE #541

Merged
merged 1 commit into from
Aug 19, 2023
Merged

Conversation

synfinatic
Copy link
Owner

  • AutoConfigCheck workflow now looks at the AWS_CONFIG_FILE env var
  • config-profiles now offers an explict flag
  • Refactor code

Fixes: #540

@codecov
Copy link

codecov bot commented Aug 19, 2023

Codecov Report

Merging #541 (acc84fb) into main (83c067f) will decrease coverage by 0.06%.
The diff coverage is 83.33%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #541      +/-   ##
==========================================
- Coverage   80.65%   80.58%   -0.06%     
==========================================
  Files          24       25       +1     
  Lines        2904     2941      +37     
==========================================
+ Hits         2342     2370      +28     
- Misses        494      500       +6     
- Partials       68       71       +3     
Files Changed Coverage Δ
internal/awsconfig/config.go 75.68% <83.33%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83c067f...acc84fb. Read the comment docs.

- AutoConfigCheck workflow now looks at the AWS_CONFIG_FILE env var
- `config-profiles` now offers an explict flag
- Refactor code

Fixes: #540
@synfinatic synfinatic merged commit 82e6d09 into main Aug 19, 2023
@synfinatic synfinatic deleted the honor-env-var branch August 19, 2023 01:15
@argoyle
Copy link

argoyle commented Aug 19, 2023

Thanks for superquick resolution ❤️

@synfinatic
Copy link
Owner Author

@argoyle If you get a chance, pull down the code and build it locally and LMK if everything works for you now.

@argoyle
Copy link

argoyle commented Aug 21, 2023

I did a go install github.com/synfinatic/aws-sso-cli/cmd/aws-sso@main and now it no longer wants to update ~/.aws/config 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Honor $AWS_CONFIG_FILE env variable
2 participants