Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite url code and support granted-containers #401

Merged
merged 1 commit into from
May 14, 2022

Conversation

synfinatic
Copy link
Owner

  • Add support for Granted Containers option
  • Rewrite internal/utils/url.go API completely
  • Rework the setup wizard to handle new options for Firefox/Exec

Fixes: #400

@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #401 (5c9d61a) into main (3b79f5a) will increase coverage by 1.01%.
The diff coverage is 88.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #401      +/-   ##
==========================================
+ Coverage   77.47%   78.48%   +1.01%     
==========================================
  Files          21       22       +1     
  Lines        2526     2593      +67     
==========================================
+ Hits         1957     2035      +78     
+ Misses        496      490       -6     
+ Partials       73       68       -5     
Impacted Files Coverage Δ
sso/awssso.go 65.96% <ø> (ø)
sso/settings.go 75.46% <80.85%> (+8.14%) ⬆️
internal/url/url.go 90.26% <90.26%> (ø)
internal/url/logger.go 100.00% <100.00%> (ø)
sso/awssso_auth.go 80.79% <100.00%> (+1.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b79f5a...5c9d61a. Read the comment docs.

@synfinatic synfinatic force-pushed the url-formatter-containers branch 5 times, most recently from b6c5849 to ef130b9 Compare May 13, 2022 23:01
- Add support for Granted Containers option
- Rewrite internal/utils/url.go API completely
- Rework the setup wizard to handle new options for Firefox/Exec

Fixes: #400
@synfinatic synfinatic force-pushed the url-formatter-containers branch from ef130b9 to 5c9d61a Compare May 13, 2022 23:34
@synfinatic synfinatic merged commit ecea3af into main May 14, 2022
@synfinatic synfinatic deleted the url-formatter-containers branch May 14, 2022 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for granted container plugin
1 participant