Fix auto-complete when DefaultSSO != Default #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users who chose something other than to set `DefaultSSO: Default` would find that auto-complete would present the wrong values or in the case of no `Default` instance, no options at all. We now load the config file and find the user specificed DefaultSSO and load those values from the cache. Fixes: #249
Codecov Report
@@ Coverage Diff @@
## main #253 +/- ##
=======================================
Coverage 45.03% 45.03%
=======================================
Files 11 11
Lines 1781 1781
=======================================
Hits 802 802
Misses 915 915
Partials 64 64
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users who chose something other than to set
DefaultSSO: Defaultwould find that auto-complete would present the wrong values or
in the case of no
Defaultinstance, no options at all.We now load the config file and find the user specificed DefaultSSO
and load those values from the cache.
Fixes: #249