Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config support and Profile to Roles #225

Merged
merged 1 commit into from
Jan 3, 2022
Merged

Add config support and Profile to Roles #225

merged 1 commit into from
Jan 3, 2022

Conversation

synfinatic
Copy link
Owner

  • Roles now support specifying a custom Profile value
    which is used as AWS_SSO_PROFILE and for the profile name
    in ~/.aws/config
  • Add support for the config command which generates the necessary
    profile entries in ~/.aws/config
  • Add StringReplace function for ProfileFormat

Refs: #157, #212

@codecov
Copy link

codecov bot commented Jan 3, 2022

Codecov Report

Merging #225 (78a0882) into main (8bf51cc) will increase coverage by 0.83%.
The diff coverage is 64.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #225      +/-   ##
==========================================
+ Coverage   42.23%   43.06%   +0.83%     
==========================================
  Files          10       11       +1     
  Lines        1655     1702      +47     
==========================================
+ Hits          699      733      +34     
- Misses        895      905      +10     
- Partials       61       64       +3     
Impacted Files Coverage Δ
sso/cache_roles.go 62.12% <62.12%> (ø)
sso/cache.go 39.28% <78.57%> (-7.02%) ⬇️
storage/storage.go 86.95% <100.00%> (+0.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ce43f8...78a0882. Read the comment docs.

@synfinatic synfinatic force-pushed the update-config branch 3 times, most recently from 8688c39 to e8c9ec9 Compare January 3, 2022 19:48
* Roles now support specifying a custom `Profile` value
    which is used as `AWS_SSO_PROFILE` and for the profile name
    in ~/.aws/config
* Add support for the `config` command which generates the necessary
    profile entries in ~/.aws/config
* Add StringReplace function for ProfileFormat
* Refactor *AWSRoleFlat & *Roles into cache_roles.go
* Add a bunch of unit tests

Refs: #157, #212
@synfinatic synfinatic merged commit 170fd62 into main Jan 3, 2022
@synfinatic synfinatic deleted the update-config branch January 3, 2022 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant