console command now honors non-Default AWS SSO instances
#220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users using `--sso` with `eval` or `exec` and then running `console` would find the latter command would fail because it did not know which AWS SSO instance was used with the previous command. We now set AWS_SSO environment variable so this value is automatically tracked with `console`, `list`, etc. Fixes: #208
Codecov Report
@@ Coverage Diff @@
## main #220 +/- ##
=======================================
Coverage 41.24% 41.24%
=======================================
Files 10 10
Lines 1622 1622
=======================================
Hits 669 669
Misses 897 897
Partials 56 56
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users using
--ssowithevalorexecand then runningconsolewould find the latter command would fail becauseit did not know which AWS SSO instance was used with the
previous command.
We now set AWS_SSO environment variable so this value is
automatically tracked with
console,list, etc.Fixes: #208