Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Via role option is now a tag #202

Merged
merged 1 commit into from
Dec 28, 2021
Merged

Via role option is now a tag #202

merged 1 commit into from
Dec 28, 2021

Conversation

synfinatic
Copy link
Owner

  • Via role option is now a searchable tag
  • Consistently always zero pad AccountIDs
  • Tags are now returned in sorted order via the tags command

Fixes: #199

 * Via role option is now a searchable tag
 * Consistently always zero pad AccountIDs
 * Tags are now returned in sorted order via the `tags` command

Fixes: #199
@codecov
Copy link

codecov bot commented Dec 28, 2021

Codecov Report

Merging #202 (1873776) into main (138c655) will decrease coverage by 0.07%.
The diff coverage is 22.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #202      +/-   ##
==========================================
- Coverage   41.41%   41.34%   -0.08%     
==========================================
  Files          10       10              
  Lines        1608     1611       +3     
==========================================
  Hits          666      666              
- Misses        887      889       +2     
- Partials       55       56       +1     
Impacted Files Coverage Δ
sso/cache.go 42.38% <12.50%> (-0.33%) ⬇️
sso/settings.go 58.86% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 138c655...1873776. Read the comment docs.

@synfinatic synfinatic merged commit 0ecd005 into main Dec 28, 2021
@synfinatic synfinatic deleted the via-tag branch December 28, 2021 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider Via as a tag
1 participant