Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New logger v2 #1025

Merged
merged 10 commits into from
Aug 20, 2024
Merged

New logger v2 #1025

merged 10 commits into from
Aug 20, 2024

Conversation

synfinatic
Copy link
Owner

@synfinatic synfinatic commented Aug 15, 2024

replace logrus with log/slog

Fixes: #1001

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 45.58824% with 111 lines in your changes missing coverage. Please review.

Project coverage is 51.06%. Comparing base (172f1c3) to head (9956c65).
Report is 11 commits behind head on main.

Files Patch % Lines
cmd/aws-sso/main.go 0.00% 20 Missing ⚠️
cmd/aws-sso/login_cmd.go 0.00% 10 Missing ⚠️
cmd/aws-sso/setup_wizard.go 0.00% 8 Missing ⚠️
internal/sso/awssso.go 58.82% 7 Missing ⚠️
internal/sso/cache.go 68.42% 6 Missing ⚠️
cmd/aws-sso/exec_cmd.go 0.00% 5 Missing ⚠️
cmd/aws-sso/interactive.go 0.00% 5 Missing ⚠️
cmd/aws-sso/list_cmd.go 0.00% 5 Missing ⚠️
internal/sso/awssso_auth.go 76.19% 5 Missing ⚠️
internal/sso/settings.go 58.33% 4 Missing and 1 partial ⚠️
... and 15 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1025      +/-   ##
==========================================
- Coverage   51.18%   51.06%   -0.12%     
==========================================
  Files          60       59       -1     
  Lines        5006     4988      -18     
==========================================
- Hits         2562     2547      -15     
+ Misses       2351     2348       -3     
  Partials       93       93              
Flag Coverage Δ
unittests 51.06% <45.59%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/ecs/client/client.go 92.98% <100.00%> (ø)
internal/ecs/http.go 100.00% <100.00%> (ø)
internal/ecs/server/default.go 100.00% <100.00%> (ø)
internal/ecs/server/httplog.go 100.00% <100.00%> (ø)
internal/ecs/server/profile.go 100.00% <100.00%> (ø)
internal/ecs/server/server.go 92.94% <100.00%> (ø)
internal/ecs/server/slotted.go 100.00% <100.00%> (ø)
internal/helper/helper.go 69.61% <100.00%> (ø)
internal/sso/logger.go 100.00% <100.00%> (ø)
internal/sso/options.go 100.00% <100.00%> (ø)
... and 29 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 172f1c3...9956c65. Read the comment docs.

@synfinatic synfinatic force-pushed the new-logger-v2 branch 3 times, most recently from 84e5944 to 67287db Compare August 15, 2024 14:29
@synfinatic synfinatic force-pushed the new-logger-v2 branch 2 times, most recently from b49ecfc to 96cb8ed Compare August 15, 2024 15:00
@synfinatic synfinatic force-pushed the new-logger-v2 branch 3 times, most recently from 9a162b7 to 157dd0f Compare August 20, 2024 00:25
@synfinatic synfinatic merged commit ae2a0f4 into main Aug 20, 2024
5 of 7 checks passed
@synfinatic synfinatic deleted the new-logger-v2 branch August 20, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace logrus with slog
1 participant