Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-introduce startup delay #441

Closed
symposion opened this issue Mar 29, 2017 · 4 comments
Closed

Re-introduce startup delay #441

symposion opened this issue Mar 29, 2017 · 4 comments

Comments

@symposion
Copy link
Owner

symposion commented Mar 29, 2017

Make it delay if it doesn't find a version attribute - trying again repeatedly for up to 20 seconds before giving up.

@symposion symposion changed the title Investigate new startup errors Re-introduce startup delay Mar 29, 2017
@liquidox
Copy link
Contributor

I've seen this once today, I don't mind loading a debug version and seeing if I can reproduce it sometimes.

Mine was:
"5eShapedCompanion 1490787091753 INFO : Detected sheet version as : undefined"

PS.
I am also getting:

"Error: No attribute or sheet field found for character_id -KgOpR9ki-sb0bcVF9L0 named version"
"Error: No attribute or sheet field found for character_id -KcsyziMOLFvlp1gJaxt named sheet_opened"
"data.skills_srd"

New, or related to a previous bug? I remember similar errors...

@symposion
Copy link
Owner Author

Hey, yeah, I've been debugging this in someone else SKT campaign. It's the same bug as before but I thought Riley had nailed at the Roll20 end. Basically the sheetworker completion callback is getting called before the sheetworkers are actually complete. In fact, in this case, it gets called before they even start. What other script do you have installed in the campaign, BTW?

@liquidox
Copy link
Contributor

liquidox commented Mar 29, 2017

G  Critical
G  GroupInitiative
G  TokenNameNumber
TurnMarker
G  Vector Math
G  MatrixMath
G  Path Math
G  Torch
TokenMod
ApplyDamage
No Token Rotation
HealthColors
Calendar
5eShapedCompanion
TableExport
G  Dynamic Light Helper
RecursiveTable
GroupCheck
ChatSetAttr

@symposion
Copy link
Owner Author

Yeah, so I suspect that HealthColors may be making this worse. It also does sheetworker stuff on startup (i believe) and I think there's a problem with the Roll20 implementation if multiple scripts are trying to fire off sheetworkers at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants