-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Conversation
Well @Tobion, then this change is fine for me. |
@fabpot is there an argument against it? |
As far as I know, SensioGeneratorBundle is not working correctly, if you switch your Symfony application to PSR-4 with a namespace prefix (filed as sensiolabs/SensioGeneratorBundle#264). Maybe this issue should be fixed first. |
👍 |
-1 for including |
@wouterj please explain negative votes. |
@Tobion Is there any functionality difference at all with this? It seems like I'd still be able to put anything into I guess I'm asking, what's the motivation for this? But at the same time, what's the motivation against this if it keeps the same functionality as now? |
Hmm, seems like I understood PSR-4 wrongly. As it turns out, empty namespaces will work just like empty namespaces in PSR-0. However, still having However, the remaining doubt won't stop me from changing my -1 into a neutral vote. |
IMO , the "pros" are that PSR-4 is loaded faster than PSR-0, the "cons" are that PEAR-like structures will be no longer supported with PSR-0.
If PSR-4 is target as |
Btw, PSR-0 is deprecated by now anyway.
|
Merged #796 into 2.7 as this is also the branch where we adjusted symfony itself to use PSR-4. So this is consistent. |
The lock file needs to be updated so the warning about out-of-sync does't appear. This will be done with the next beta release anyway. |
symfony/symfony#11189 for Symfony Standard