Prefer php-http/discovery over nyholm/psr7 when installed

[nicolas-grekas]

Q	A
License	MIT
Doc issue/PR	-

Note that php-http/discovery itself defaults to nyholm/psr7 so in practice this shouldn't change much, except for people that want to rely on another PSR-17 implementation.

[github-actions]

Thanks for the PR 😍

How to test these changes in your application

1. Define the SYMFONY_ENDPOINT environment variable:

   # On Unix-like (BSD, Linux and macOS)
   export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1198/index.json
   # On Windows
   SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1198/index.json

2. Install the package(s) related to this recipe:

   composer req 'symfony/flex:^1.16'
   composer req 'nyholm/psr7:^1.0' 'php-http/discovery:^1.18'

3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

   # On Unix-like (BSD, Linux and macOS)
   unset SYMFONY_ENDPOINT
   # On Windows
   SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

[tacman]

The recipe throws a warning about not being installable.

Skipping recipe for nyholm/psr7: all versions of the recipe conflict with your package versions.

~/g/museado/museado$ composer why nyholm/psr7
php-http/discovery 1.19.4 conflicts nyholm/psr7 (<1.0)   
toshy/bunnynet-php 4.5.0  requires  nyholm/psr7 (^1.6.1)
 
~/g/museado/museado$ composer why php-http/discovery
knplabs/github-api                v3.14.1 requires  php-http/discovery (^1.12) 
meilisearch/meilisearch-php       v1.10.0 requires  php-http/discovery (^1.7)  
php-http/multipart-stream-builder 1.4.2   requires  php-http/discovery (^1.15) 
symfony/http-client               v7.1.4  conflicts php-http/discovery (<1.15) 
symfony/psr-http-message-bridge   v7.1.4  conflicts php-http/discovery (<1.15) 

I got an explanation here: ToshY/BunnyNet-PHP#141

but is there a way to remove the warning? It's not causing any harm, of course.

[derrabus]

Is this a warning? I read this as: FYI, I didn't install a recipe for this package and here's the reason why.

[tacman]

Yes, it's not a warning, but it's a message that says "I didn't do something because there was a conflict". So I'd love to avoid seeing that message, I think it happens on every deployment.

[nicolas-grekas]

I don't have a solution for skipping this warning. You can just ignore it for now.
We don't want this recipe installed when php-http/discovery is also installed, and that's the way to do it...

[tacman]

ah, that makes more sense. Thanks.