-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update toolchain version, script, and README.md
#96
Conversation
Another option would be to suggest |
Time Change: -96.5ms (1%) Total Time: 8,702.5ms ℹ️ View Unchanged
|
I suppose both could be mentioned, then they can choose what fits their needs best? |
I think we need to provide two section, the first is for users of JavaScriptKit and the second is for contributors of JavaScriptKit. |
install-toolchain.sh
script in README.md
README.md
That's updated, |
c413132
to
045f5d1
Compare
045f5d1
to
fb798a5
Compare
scripts/install-toolchain.sh
Outdated
@@ -18,13 +18,16 @@ fi | |||
|
|||
case $(uname -s) in | |||
Darwin) | |||
toolchain_download="$swift_tag-osx.tar.gz" | |||
toolchain_download="$swift_tag-macos-x86_64.tar.gz" | |||
echo '-macos' >> .swift-version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still waiting for the new 5.3 toolchain to be tagged tonight that fixes this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's cleaned up now, ready for review.
f823585
to
e14ee9d
Compare
README.md
Outdated
```sh | ||
$ ./scripts/install-toolchain.sh | ||
$ swift --version | ||
Swift version 5.3-dev (LLVM 09686f232a, Swift 5a196c7f13) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think vendor name can be updated 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found that swiftwasm/swift#1921 is not included in 5.3 branch 😢 But now, it's ok without SwiftWasm vendor name...
The toolchain snapshot suggested in
README.md
is outdated. I think we should recommend using the script to install it automatically.Resolves #95.