Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Use Swift SDK by default #285

Merged
merged 3 commits into from
Feb 28, 2025
Merged

CI: Use Swift SDK by default #285

merged 3 commits into from
Feb 28, 2025

Conversation

kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented Feb 28, 2025

In other words, drop toolchain-style installation support.

swiftwasm/swift#5604

Copy link

Time Change: +234ms (2%)

Total Time: 9,711ms

Test name Duration Change
Serialization/JavaScript function call through Wasm import 26ms +7ms (25%) 🚨
Serialization/JavaScript function call through Wasm import with int 15ms +1ms (8%) 🔍
Serialization/Swift Int to JavaScript with call 1,069ms +59ms (5%) 🔍
View Unchanged
Test name Duration Change
Serialization/JavaScript function call from Swift 112ms -3ms (2%)
Serialization/Swift Int to JavaScript with assignment 352ms +9ms (2%)
Serialization/JavaScript Number to Swift Int 297ms +10ms (3%)
Serialization/Swift String to JavaScript with assignment 413ms +17ms (3%)
Serialization/Swift String to JavaScript with call 1,123ms +49ms (4%)
Serialization/JavaScript String to Swift String 3,631ms +63ms (1%)
Object heap/Increment and decrement RC 2,659ms +20ms (0%)
View Baselines
Test name Duration
Serialization/Call JavaScript function directly 3ms
Serialization/Assign JavaScript number directly 4ms
Serialization/Call with JavaScript number directly 3ms
Serialization/Write JavaScript string directly 2ms
Serialization/Call with JavaScript string directly 3ms

@kateinoigakukun kateinoigakukun force-pushed the yt/use-swift-sdk branch 4 times, most recently from 7e682c5 to b6349b0 Compare February 28, 2025 09:09
In other words, drop toolchain-style installation support
@kateinoigakukun kateinoigakukun merged commit 5148e4f into main Feb 28, 2025
7 of 8 checks passed
@kateinoigakukun kateinoigakukun deleted the yt/use-swift-sdk branch February 28, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant