mark CAtomic import as internal or implementation-only #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes rdar://134894555, fixes swiftlang#195
|
@swift-ci Please test |
Kyle-Ye
approved these changes
Sep 17, 2024
|
Confirmed it. SE409 stated that only main and release/5.9 needed this flag, but it is actually also needed for 5.10 compiler. Tested with Xcode 15.3 + Swift 5.10 
|
Kyle-Ye
requested changes
Sep 17, 2024
Co-authored-by: Kyle <kyle201817146@gmail.com>
|
@swift-ci Please test |
Kyle-Ye
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: fixes rdar://134894555, fixes #195
Summary
The CAtomic target defined in this package is causing issues when verifying module interfaces of projects that depend on Swift-Markdown. This PR marks the import of CAtomic in Swift-Markdown as
internalor@_implementationOnly, depending on the compiler in use, to sidestep the issue.Dependencies
None
Testing
Ensure that no behavior has changed.
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
./bin/testscript and it succeeded