fix crash when resizing tiled scratchpad windows #7680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This crash can be reproduced with the config/script mentioned in #6693 (comment) |
|
It would prolly make sense to check container_is_scratchpad_hidden_or_child at the beginning of container_resize_tiled. |
bretello
force-pushed
the
fix-scratchpad-tiled-container-resize-crash
branch
from
aee1051 to
9bd0c5c
Compare
emersion
reviewed
Jul 18, 2023
bretello
force-pushed
the
fix-scratchpad-tiled-container-resize-crash
branch
from
9bd0c5c to
d16bdbd
Compare
rpigott
requested changes
Jul 18, 2023
bretello
force-pushed
the
fix-scratchpad-tiled-container-resize-crash
branch
from
d16bdbd to
ef94156
Compare
|
Ehm, can you maybe rebase this so it can be merged? I dunno what github's problem with it is. |
Splitting and then hiding a scratchpad container results in a segfault. fixes swaywm#6693
bretello
force-pushed
the
fix-scratchpad-tiled-container-resize-crash
branch
from
ef94156 to
18dd3b0
Compare
|
@rpigott Done. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting and then hiding a scratchpad container results in a segfault.
fixes #6693