fix: cmd_sticky crash sway with empty container #2821
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I used my sticky shortcut on an empty workspace (mouse pointer over wallpaper), sway crash with stack trace:
Checking if the container is null solve this.
But this fix will mislead the cmd_sticky to think that the container is a tiled container.
If this is a bug, do you prefer testing if the container is null in cmd_sticky function ?