Build break

[J0nnyMak0]

ninja: Entering directory `build'
[573/613] Compiling C object sway/sway.p/tree_container.c.o
FAILED: sway/sway.p/tree_container.c.o
cc -Isway/sway.p -Isway -I../sway -Iinclude -I../include -Isubprojects/wlroots/include -I../subprojects/wlroots/include -Iprotocols -I/usr/include/cairo -I/usr/include/libpng16 -I/usr/include/freetype2 -I/usr/include/harfbuzz -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/sysprof-4 -I/usr/include/pixman-1 -I/usr/include/libdrm -I/usr/include/json-c -I/usr/include/libevdev-1.0 -I/usr/include/pango-1.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/fribidi -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror -std=c11 -O0 -g -DWLR_USE_UNSTABLE -Wno-unused-parameter -Wno-unused-result -Wno-missing-braces -Wundef -Wvla '-DSYSCONFDIR="//usr/local/etc"' '-DSWAY_VERSION="1.9-dev-7d0351b4 (" __DATE__ ", branch '"'"'master'"'"')"' -fmacro-prefix-map=../= -pthread -MD -MQ sway/sway.p/tree_container.c.o -MF sway/sway.p/tree_container.c.o.d -o sway/sway.p/tree_container.c.o -c ../sway/tree/container.c
../sway/tree/container.c: In function ‘set_fullscreen’:
../sway/tree/container.c:1136:36: error: initialization of ‘long unsigned int’ from ‘struct wlr_drm_format_set *’ makes integer from pointer without a cast [-Werror=int-conversion]
 1136 |                         .formats = &scanout_formats,
      |                                    ^
../sway/tree/container.c:1136:36: note: (near initialization for ‘tranches[0].formats.len’)
../sway/tree/container.c:1140:36: error: initialization of ‘long unsigned int’ from ‘const struct wlr_drm_format_set *’ makes integer from pointer without a cast [-Werror=int-conversion]
 1140 |                         .formats = renderer_formats,
      |                                    ^~~~~~~~~~~~~~~~
../sway/tree/container.c:1140:36: note: (near initialization for ‘tranches[1].formats.len’)
../sway/tree/container.c:1146:29: error: initialization of ‘long unsigned int’ from ‘struct wlr_linux_dmabuf_feedback_v1_tranche *’ makes integer from pointer without a cast [-Werror=int-conversion]
 1146 |                 .tranches = tranches,
      |                             ^~~~~~~~
../sway/tree/container.c:1146:29: note: (near initialization for ‘feedback.tranches.size’)
../sway/tree/container.c:1147:18: error: ‘const struct wlr_linux_dmabuf_feedback_v1’ has no member named ‘tranches_len’; did you mean ‘tranches’?
 1147 |                 .tranches_len = sizeof(tranches) / sizeof(tranches[0]),
      |                  ^~~~~~~~~~~~
      |                  tranches
../sway/tree/container.c:1147:33: error: excess elements in struct initializer [-Werror]
 1147 |                 .tranches_len = sizeof(tranches) / sizeof(tranches[0]),
      |                                 ^~~~~~
../sway/tree/container.c:1147:33: note: (near initialization for ‘feedback’)
cc1: all warnings being treated as errors
[590/613] Compiling C object swaybar/swaybar.p/ipc.c.o
ninja: build stopped: subcommand failed.

[BBaoVanC]

I'm seeing this too. Also might be related that now I am getting a sway crash when a program goes fullscreen, which seems to hit some code nearby this error:

(gdb) bt
#0  __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at pthread_kill.c:44
#1  0x00007f9668dda953 in __pthread_kill_internal (signo=6, threadid=<optimized out>) at pthread_kill.c:78
#2  0x00007f9668d8bea8 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
#3  0x00007f9668d7553d in __GI_abort () at abort.c:79
#4  0x00007f9668d7545c in __assert_fail_base
    (fmt=0x7f9668eeed68 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", assertion=0x7f96690998a7 "tranches_len > 0", file=0x7f9669099678 "types/wlr_linux_dmabuf_v1.c", line=502, function=<optimized out>) at assert.c:92
#5  0x00007f9668d849f6 in __assert_fail
    (assertion=assertion@entry=0x7f96690998a7 "tranches_len > 0", file=file@entry=0x7f9669099678 "types/wlr_linux_dmabuf_v1.c", line=line@entry=502, function=function@entry=0x7f966909bcf0 <__PRETTY_FUNCTION__.1.lto_priv.61> "feedback_compile") at assert.c:101
#6  0x00007f966904a871 in feedback_compile (feedback=feedback@entry=0x7fffbf9ad6f0) at ../wlroots-git/types/wlr_linux_dmabuf_v1.c:502
#7  0x00007f966904b66d in wlr_linux_dmabuf_v1_set_surface_feedback (linux_dmabuf=<optimized out>, wlr_surface=<optimized out>, feedback=feedback@entry=0x7fffbf9ad6f0)
    at ../wlroots-git/types/wlr_linux_dmabuf_v1.c:1015
#8  0x000056211aa44d56 in set_fullscreen (con=con@entry=0x56211cb70500, enable=enable@entry=true) at ../sway/sway/tree/container.c:1149
#9  0x000056211aa45f4d in container_fullscreen_workspace (con=0x56211cb70500) at ../sway/sway/tree/container.c:1160
#10 container_fullscreen_workspace (con=0x56211cb70500) at ../sway/sway/tree/container.c:1155
#11 0x000056211aa2ee0e in cmd_fullscreen (argv=0x56211d3f04e8, argc=0) at ../sway/sway/commands/fullscreen.c:54
#12 cmd_fullscreen (argc=0, argv=0x56211d3f04e8) at ../sway/sway/commands/fullscreen.c:12
#13 0x000056211aa05b51 in execute_command (_exec=<optimized out>, seat=0x56211cffe850, con=0x0) at ../sway/sway/commands.c:295
#14 0x000056211aa31186 in seat_execute_command (seat=0x56211cffe850, binding=0x56211cfe4060) at ../sway/sway/commands/bind.c:632
#15 0x000056211aa1c84b in handle_key_event (keyboard=0x56211d122360, event=0x7fffbf9adc10) at ../sway/sway/input/keyboard.c:489
#16 0x00007f96690d7f6e in wl_signal_emit_mutable (signal=signal@entry=0x56211d2bdd88, data=data@entry=0x7fffbf9adc10) at ../wayland-1.21.0/src/wayland-server.c:2179
#17 0x00007f966903eb35 in wlr_keyboard_notify_key (keyboard=0x56211d2bdc50, event=0x7fffbf9adc10) at ../wlroots-git/types/wlr_keyboard.c:102
#18 0x00007f96690d7f6e in wl_signal_emit_mutable (signal=signal@entry=0x56211cfb2400, data=data@entry=0x7fffbf9adc10) at ../wayland-1.21.0/src/wayland-server.c:2179
#19 0x00007f966903eb35 in wlr_keyboard_notify_key (keyboard=0x56211cfb22c8, event=0x7fffbf9adc10) at ../wlroots-git/types/wlr_keyboard.c:102
#20 0x00007f96690143de in handle_keyboard_key (kb=0x56211cfb22c8, event=0x56211d3d47c0) at ../wlroots-git/backend/libinput/keyboard.c:54
#21 handle_libinput_event (event=0x56211d3d47c0, backend=0x56211c41e710) at ../wlroots-git/backend/libinput/events.c:165
#22 handle_libinput_readable (fd=<optimized out>, mask=<optimized out>, _backend=<optimized out>) at ../wlroots-git/backend/libinput/backend.c:58
#23 handle_libinput_readable (fd=<optimized out>, mask=<optimized out>, _backend=0x56211c41e710) at ../wlroots-git/backend/libinput/backend.c:48
#24 0x00007f96690d99e2 in wl_event_loop_dispatch (loop=0x56211c41cbd0, timeout=timeout@entry=-1) at ../wayland-1.21.0/src/event-loop.c:1027
#25 0x00007f96690da197 in wl_display_run (display=0x56211c41cae0) at ../wayland-1.21.0/src/wayland-server.c:1431
#26 0x000056211a9feb81 in server_run (server=<optimized out>) at ../sway/sway/server.c:332
#27 main (argc=<optimized out>, argv=0x7fffbf9ae0d8) at ../sway/sway/main.c:415

EDIT: I think I fixed it, I'll make a pull request.

[frkli1965]

Rollback WLROOTS commits 0c966f10 and 8c5713bd (06/02/23) in order to negate these problems.

See:-

https://gitlab.freedesktop.org/wlroots/wlroots/-/commit/0c966f102c1d1940718cf96888036605e35074fb
https://gitlab.freedesktop.org/wlroots/wlroots/-/commit/8c5713bd7a37e3b32ee3df0df0ddc59f3d32efd2

Reckless to have permitted the above changes without considering the impact they may have had on Sway given that the two are inextricably linked. Wouldn't be surprised if other dependent DEs have been severely affected as well.

[emersion]

Reckless to have permitted the above changes without considering the impact they may have had on Sway given that the two are inextricably linked. Wouldn't be surprised if other dependent DEs have been severely affected as well.

This is by design. Sway master tracks wlroots master, and breaking wlroots changes are expected.