-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate to using/urfave/cli/v2
#618
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you help change:
- imported
github.com/urfave/cli
github.com/urfave/cli/v2
- executed
go mod tidy
and commitedgo.mod
file
That will be work for this change. 😄
Codecov Report
@@ Coverage Diff @@
## master #618 +/- ##
=======================================
Coverage 85.84% 85.84%
=======================================
Files 7 7
Lines 1696 1696
=======================================
Hits 1456 1456
Misses 150 150
Partials 90 90 Continue to review full report at Codecov.
|
Hi @easonlin404 thank you for your reply I updated it, now the checks are passing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Describe the PR
go get -u github.com/swaggo/swag/cmd/swag
results in some errors because thehttps://github.com/urfave/cli
implementation changed.Snippet of the error message:
Additional context
Sorry for the number of commits, I edited directly on GitHub.