Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug in array param in body #579

Merged
merged 3 commits into from
Dec 12, 2019
Merged

fix bug in array param in body #579

merged 3 commits into from
Dec 12, 2019

Conversation

sdghchj
Copy link
Member

@sdghchj sdghchj commented Dec 10, 2019

@codecov-io
Copy link

codecov-io commented Dec 11, 2019 •
edited
Loading

Codecov Report

Merging #579 into master will increase coverage by 0.07%.
The diff coverage is 89.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #579      +/-   ##
==========================================
+ Coverage   87.44%   87.52%   +0.07%     
==========================================
  Files           7        7              
  Lines        1617     1611       -6     
==========================================
- Hits         1414     1410       -4     
+ Misses        119      118       -1     
+ Partials       84       83       -1
Impacted Files Coverage Δ
operation.go 92.62% <100%> (+0.01%) ⬆️
parser.go 82.63% <88.88%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a478a32...46add39. Read the comment docs.

@easonlin404 easonlin404 requested a review from ubogdan December 11, 2019 09:47
easonlin404
easonlin404 previously approved these changes Dec 11, 2019
View reviewed changes
Copy link
Member

@easonlin404 easonlin404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ubogdan
ubogdan requested changes Dec 11, 2019
View reviewed changes
@ubogdan
Copy link
Contributor

ubogdan commented Dec 12, 2019

@sdghchj I asked you to do a simple change. Code review takes time and i don't have too much lately.

@sdghchj
Copy link
Member Author

sdghchj commented Dec 12, 2019 •
edited
Loading

@ubogdan

reverted

ubogdan
ubogdan approved these changes Dec 12, 2019
View reviewed changes
Copy link
Contributor

@ubogdan ubogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ubogdan ubogdan merged commit b731715 into swaggo:master Dec 12, 2019
@ubogdan
Copy link
Contributor

ubogdan commented Dec 12, 2019 •
edited
Loading

Thanks for your contribution!

@easonlin404 easonlin404 mentioned this pull request Dec 13, 2019
Closed
This was referenced Dec 21, 2019
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@easonlin404 easonlin404 easonlin404 left review comments

@ubogdan ubogdan ubogdan approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sdghchj @codecov-io @ubogdan @easonlin404