Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct error in checking for primitive data type #516

Merged
merged 2 commits into from
Sep 18, 2019

Conversation

bruceadowns
Copy link
Contributor

Describe the PR
This PR corrects the error in checking for primitive data type.

Relation issue
Bug introduces in d74ed70.

Additional context
I am seeing this error in the latest build:

$ swag init -g cmd/cnc.go
2019/09/11 11:35:02 Generate swagger docs....
2019/09/11 11:35:02 Generate general API Info, search dir:./
2019/09/11 11:35:02 ParseComment error in file cmd/cnc.go :can not find schema type: "cmd.int"

@codecov-io
Copy link

codecov-io commented Sep 11, 2019

Codecov Report

Merging #516 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #516   +/-   ##
=======================================
  Coverage   86.78%   86.78%           
=======================================
  Files           7        7           
  Lines        1536     1536           
=======================================
  Hits         1333     1333           
  Misses        119      119           
  Partials       84       84
Impacted Files Coverage Δ
operation.go 92.6% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d74ed70...785f056. Read the comment docs.

Copy link
Member

@easonlin404 easonlin404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder that what cause bug in d74ed70? Any thought? @ubogdan

Copy link
Contributor

@ubogdan ubogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ubogdan ubogdan merged commit b09d3f5 into swaggo:master Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants