Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude developer tools from go modules. #493

Merged
merged 4 commits into from
Aug 11, 2019
Merged

Conversation

pei0804
Copy link
Member

@pei0804 pei0804 commented Aug 9, 2019

Describe the PR
swag is't need go lint for go modules.

@pei0804 pei0804 requested review from a team and removed request for a team August 9, 2019 02:39
@pei0804
Copy link
Member Author

pei0804 commented Aug 9, 2019

I think about a little more.

Copy link
Member Author

@pei0804 pei0804 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is necessary to investigate the cause of build failure.

@codecov-io
Copy link

codecov-io commented Aug 11, 2019

Codecov Report

Merging #493 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #493   +/-   ##
=======================================
  Coverage   87.05%   87.05%           
=======================================
  Files           7        7           
  Lines        1522     1522           
=======================================
  Hits         1325     1325           
  Misses        115      115           
  Partials       82       82

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16ebb32...2119ac7. Read the comment docs.

@pei0804 pei0804 force-pushed the go-mod-ignore-tool branch 5 times, most recently from c3e5e2c to a1d3a05 Compare August 11, 2019 03:00
@pei0804
Copy link
Member Author

pei0804 commented Aug 11, 2019

@easonlin404
plz review.

@pei0804 pei0804 force-pushed the go-mod-ignore-tool branch from a1d3a05 to 2119ac7 Compare August 11, 2019 03:08
Copy link
Contributor

@ubogdan ubogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ubogdan ubogdan merged commit 33a7940 into master Aug 11, 2019
@ubogdan ubogdan deleted the go-mod-ignore-tool branch August 11, 2019 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants