Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue #397: Unnecessary type field on response objects #459

Merged
merged 4 commits into from
Jul 18, 2019
Merged

fix issue #397: Unnecessary type field on response objects #459

merged 4 commits into from
Jul 18, 2019

Conversation

ubogdan
Copy link
Contributor

@ubogdan ubogdan commented Jul 17, 2019

Describe the PR
bugfix: Unnecessary type field on response objects

Relation issue
#397

Additional context
None.

@ubogdan ubogdan requested a review from easonlin404 July 17, 2019 12:26
easonlin404
easonlin404 approved these changes Jul 18, 2019
View reviewed changes
Copy link
Member

@easonlin404 easonlin404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@easonlin404 easonlin404 merged commit d8cb1c8 into master Jul 18, 2019
@easonlin404 easonlin404 deleted the fix-issue-397 branch July 18, 2019 02:16
@easonlin404 easonlin404 mentioned this pull request Jul 18, 2019
Closed
@ubogdan ubogdan mentioned this pull request Sep 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@easonlin404 easonlin404 easonlin404 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ubogdan @easonlin404