Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: remove backticks from struct field's comment #442

Merged
merged 3 commits into from
Jul 10, 2019
Merged

enhancement: remove backticks from struct field's comment #442

merged 3 commits into from
Jul 10, 2019

Conversation

ubogdan
Copy link
Contributor

@ubogdan ubogdan commented Jul 8, 2019

Describe the PR
enhancement: remove backticks from struct field's comment

Relation issue
Issue #381

Additional context
None.

@sepehrmm
Copy link

sepehrmm commented Jul 9, 2019

Can we have tests for this?

Copy link
Member

@easonlin404 easonlin404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please help to add test cases.

@codecov-io
Copy link

codecov-io commented Jul 9, 2019

Codecov Report

Merging #442 into master will decrease coverage by 0.13%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #442      +/-   ##
==========================================
- Coverage   82.62%   82.48%   -0.14%     
==========================================
  Files           7        7              
  Lines        1456     1456              
==========================================
- Hits         1203     1201       -2     
- Misses        143      144       +1     
- Partials      110      111       +1
Impacted Files Coverage Δ
parser.go 80.54% <100%> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be6d0b2...e5d0faf. Read the comment docs.

@ubogdan
Copy link
Contributor Author

ubogdan commented Jul 9, 2019

Done

Copy link
Member

@easonlin404 easonlin404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@easonlin404
Copy link
Member

@ubogdan Thanks for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants