Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chroe: update embedded swagger ui #435

Merged
merged 1 commit into from
Jul 6, 2019
Merged

chroe: update embedded swagger ui #435

merged 1 commit into from
Jul 6, 2019

Conversation

easonlin404
Copy link
Member

@easonlin404 easonlin404 commented Jul 6, 2019 •
edited
Loading

@easonlin404 easonlin404 requested a review from pei0804 July 6, 2019 09:56
pei0804
pei0804 approved these changes Jul 6, 2019
View reviewed changes
Copy link
Member

@pei0804 pei0804 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Jul 6, 2019 •
edited
Loading

Codecov Report

Merging #435 into master will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #435      +/-   ##
==========================================
- Coverage   81.83%   81.69%   -0.14%     
==========================================
  Files           7        7              
  Lines        1448     1448              
==========================================
- Hits         1185     1183       -2     
- Misses        157      158       +1     
- Partials      106      107       +1
Impacted Files Coverage Δ
parser.go 79.13% <0%> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91ec3e6...8a537f6. Read the comment docs.

@easonlin404 easonlin404 merged commit 2f348f4 into master Jul 6, 2019
@easonlin404 easonlin404 deleted the update-swagger-ui branch July 6, 2019 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pei0804 pei0804 pei0804 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the Swagger UI
3 participants
@easonlin404 @codecov-io @pei0804