parser-v2: Extend DeserializationUtils methods to enable providing a custom YAMLMapper #1935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CalemRoelofsSB
requested review from
frantuma,
HugoMario,
gracekarina and
MateuszPol
MateuszPol
approved these changes
May 24, 2023
frantuma
reviewed
May 26, 2023
There was a problem hiding this comment.
I would probably provide an option to set the YAMLFactory instead of the whole mapper, using feature provided by swagger-api/swagger-core#4397
This is because allowing to pass an arbitrary mapper with wrong or absent "Swagger configuration" would result in errors(e.g. when not cloning Yaml.mapper() or using ObjectMapperFactory) .
That said, I don't see evident issues except the above
| } | ||
|
|
||
| private static Options options = new Options(); | ||
|
|
||
| private static final Logger LOGGER = LoggerFactory.getLogger(DeserializationUtils.class); | ||
|
|
||
| private static ObjectMapper YAML_MAPPER = Yaml.mapper(); |
There was a problem hiding this comment.
Would name it yamlMapper or something..
|
@frantuma totally agree, have updated it now to accept a YAMLFactory and create the mapper using it from the ObjectMapperFactory in swagger-core |
frantuma
approved these changes
May 26, 2023
CalemRoelofsSB
deleted the
feature/extend-DeserializationUtils-with-custom-yaml-mapper
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility to set a custom YAML mapper for parsing OAS 2.0 documents with DeserializationUtils methods.