Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(validation): enum values should conform to their schema's type #2079

Merged
merged 7 commits into from
Jan 11, 2020

Conversation

ralphdoe
Copy link
Contributor

@ralphdoe ralphdoe commented Dec 5, 2019

Schema Object: enum values should conform to their schema's type

Description

Error should appear at the enum item whose type doesn't match.

Motivation and Context

How Has This Been Tested?

Added unit testing for all samples.

Screenshots (if appropriate):

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

Copy link
Contributor

@shockey shockey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested 🔧

Most of the inline content is pretty terse — @ralphdoe, ping me on Slack if you have any questions and we'll sync up!

Copy link
Contributor Author

@ralphdoe ralphdoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are done!

Copy link
Contributor

@shockey shockey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting there! I've attached a mix of changes, change requests, and some comments that aren't absolute requirements.

As always, ping me here or by Slack/email if you have any questions 😄

Copy link
Contributor

@shockey shockey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're almost there 🙂

@shockey shockey changed the title feature/validator_enum_types - Validator in schemas.js added feat(validation): enum values should conform to their schema's type Jan 11, 2020
@shockey shockey merged commit 10639cd into swagger-api:master Jan 11, 2020
@shockey
Copy link
Contributor

shockey commented Jan 11, 2020

merged 🎉

thanks @ralphdoe!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants