-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(validation): enum values should conform to their schema's type #2079
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes requested 🔧
Most of the inline content is pretty terse — @ralphdoe, ping me on Slack if you have any questions and we'll sync up!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting there! I've attached a mix of changes, change requests, and some comments that aren't absolute requirements.
As always, ping me here or by Slack/email if you have any questions 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merged 🎉 thanks @ralphdoe! |
Schema Object: enum values should conform to their schema's type
Description
Error should appear at the enum item whose type doesn't match.
Motivation and Context
How Has This Been Tested?
Added unit testing for all samples.
Screenshots (if appropriate):
Checklist
My PR contains...
src/
is unmodified: changes to documentation, CI, metadata, etc.)package.json
)My changes...
Documentation
Automated tests