deserialize as arrayModel, any model that has items and no specific type defined #4109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 27, 2022
frantuma
requested changes
Jan 28, 2022
There was a problem hiding this comment.
Possibly there is a better way to handle this as adding items to ModelImpl leaving also the field in ArrayModel will possibly break things and be source of confusion.
As this is meant to fix swagger-api/swagger-parser#1636, the best course of action would be probably to update deserializer to also deserialize to ArrayModel when type is empty AND items field is present. On the parser side, a similar change can be implemented in SwaggerDeserializer.
In both cases we would deserialize into ArrayModel and after instantiation we would set type to null as it is in source
gracekarina
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for items all Schema types.
refs: swagger-api/swagger-parser/1636