fix #3094 - avoid duplicate fields in schema classes #3102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: The various Schema subclasses (ArraySchema, BinarySchema, etc.) are defined such that they actually duplicate some of the fields from the Schema super class (e.g. type, format, default, etc.). This can create confusion when examining instances of these classes within a debugger as you will see two "type" fields for example, the base class' "type" field will be set to null and the subclass' "type" field will be set to "array" (or "binary", or "boolean", etc.). We have similar issues with the format and default fields. What: In this PR, I've fixed this by adding a protected ctor to Schema, and default ctors to the subclasses, plus I've removed some getters/setters from the subclasses that are no longer needed.
|
Please disregard the name of my bug branch. I don't know where I got "342". Should have named it "issue-3094" :) |
|
cc: @frantuma |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
The various Schema subclasses (ArraySchema, BinarySchema, etc.) are
defined such that they actually duplicate some of the fields from
the Schema super class (e.g. type, format, default, etc.). This
can create confusion when examining instances of these classes within
a debugger as you will see two "type" fields for example, the base class'
"type" field will be set to null and the subclass' "type" field will be set
to "array" (or "binary", or "boolean", etc.). We have similar issues with
the format and default fields.
What:
In this PR, I've fixed this by adding a protected ctor to Schema, and default ctors to
the subclasses, plus I've removed some getters/setters from the subclasses
that are no longer needed.