Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building swagger-core fails on Windows #4280

Closed
devopsix opened this issue Oct 27, 2022 · 0 comments · Fixed by #4281
Closed

Building swagger-core fails on Windows #4280

devopsix opened this issue Oct 27, 2022 · 0 comments · Fixed by #4281

Comments

@devopsix
Copy link
Contributor

Given OpenJDK and Apache Maven are available.

  1. Clone swagger-core project.
  2. Run mvn -N
  3. Run mvn install

Expected: Build suceeds.

Actual: Build fails.

Build fails when running unit tests for the swagger-core module.

testBooleanSchemaSerialization(io.swagger.v3.core.serialization.OpenAPI3_1SerializationTest)  Time elapsed: 0 sec  <<< FAILURE!
java.lang.AssertionError: expected [{
  "openapi" : "3.1.0",
  "components" : {
    "schemas" : {
      "test" : true
    }
  }
}] but found [{
  "openapi" : "3.1.0",
  "components" : {
    "schemas" : {
      "test" : true
    }
  }
}]
        at org.testng.Assert.fail(Assert.java:99)
        at org.testng.Assert.failNotEquals(Assert.java:1037)
        at org.testng.Assert.assertEqualsImpl(Assert.java:140)
        at org.testng.Assert.assertEquals(Assert.java:122)
        at org.testng.Assert.assertEquals(Assert.java:629)
        at org.testng.Assert.assertEquals(Assert.java:639)
        at io.swagger.v3.core.serialization.OpenAPI3_1SerializationTest.testBooleanSchemaSerialization(OpenAPI3_1SerializationTest.java:1377)

OpenAPI3_1SerializationTest.java:1377:

assertEquals(Json31.pretty(openAPI), "{\n" +
        "  \"openapi\" : \"3.1.0\",\n" +
        "  \"components\" : {\n" +
        "    \"schemas\" : {\n" +
        "      \"test\" : true\n" +
        "    }\n" +
        "  }\n" +
        "}");

Json31.pretty(String) uses Jackson's DefaultIndenter which uses the machine's line separator (System.getProperty("line.separator")), i.e. "\r\n" under Windows OS.

Swagger Core 2.2.5.SNAPHOT
Java, OpenJDK Runtime Environment 18.9 (build 11+28)
Windows 10.0.19045 Build 19045

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant