Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

$refs within items don't get added to list of schemas when isRemovingUnreferencedDefinitions #3303

Closed
eak24 opened this issue Sep 26, 2019 · 5 comments
Closed

$refs within items don't get added to list of schemas when isRemovingUnreferencedDefinitions #3303

eak24 opened this issue Sep 26, 2019 · 5 comments

Comments

@eak24
Copy link
Contributor

eak24 commented Sep 26, 2019

When the schema has an arraySchema that has items that are in turn a $ref, that ref doesn't get followed to add all of its children refs. In fact, I think this happens anytime there are refs of refs. This logic only goes one ref level deep. I was able to work around this in a PR I will post and link to this issue.
@eak24 eak24 mentioned this issue Sep 26, 2019
Closed
@eak24
Copy link
Contributor Author

eak24 commented Sep 26, 2019

Tried to make the PR through GH's online edit tool, but it got mangled. Trying again now through git.

@eak24 eak24 mentioned this issue Sep 26, 2019
Closed
@eak24
Copy link
Contributor Author

eak24 commented Sep 26, 2019

OK, I changed the branch to adhere to the contribution guidelines and cleaned up the code. Hopefully it'll pass now!

@eak24
Copy link
Contributor Author

eak24 commented Sep 27, 2019

Please let me know if I am missing anything in the way of style or logic!

frantuma added a commit that referenced this issue Oct 2, 2019
@frantuma
refs #3303 - add test
4f34a3c
frantuma added a commit that referenced this issue Oct 2, 2019
@frantuma
Merge pull request #3317 from swagger-api/bug-nested-refs-filtering
10158db 
refs #3303 - Bugfix for filtering nested $refs
@frantuma
Copy link
Member

frantuma commented Oct 2, 2019

Thanks for reporting this, fixed in #3317 (which includes #3305)

@frantuma frantuma closed this as completed Oct 2, 2019
@eak24
Copy link
Contributor Author

eak24 commented Oct 2, 2019

@frantuma thanks for taking care of this so quickly! And thanks for helping with a great product 😄

@Xarno Xarno mentioned this issue Dec 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eak24 @frantuma