Follow MS guidelines for custom exception types. #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AraHaan
reviewed
Jun 28, 2021
9 tasks
mrbean-bremen
force-pushed
the
serializable_exceptions
branch
from
8f53b14 to
bf89bf4
Compare
|
@paulushub - I've removed |
|
@mrbean-bremen Thank you, the |
mrbean-bremen
force-pushed
the
serializable_exceptions
branch
from
bf89bf4 to
d90df98
Compare
Ah right, thanks - missed this. Fixed now. |
You are on fire! you are sure you do not want to also revert the decision on contribution? 😄 |
paulushub
requested review from
mrbean-bremen and
AraHaan
and removed request for
paulushub and
AraHaan
Quite sure 😁 |
- make custom exception types serializable.
mrbean-bremen
force-pushed
the
serializable_exceptions
branch
from
d90df98 to
95b1077
Compare
mrbean-bremen
approved these changes
Dec 29, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Dec 30, 2023
… exception types serializable.
github-actions bot
pushed a commit
to inforithmics/SVG
that referenced
this pull request
Jan 6, 2024
… custom exception types serializable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
No existing recorded issue.
What does this implement/fix? Explain your changes.
If using this SVG library within a .Net framework AppDomain, exceptions must be serializable to cross AppDomain boundaries.
In addition, implement common exception constructors, in line with guidance at https://docs.microsoft.com/en-us/dotnet/standard/exceptions/best-practices-for-exceptions