Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse performance optimizations #786

Closed

Conversation

wieslawsoltes
Copy link
Contributor

@wieslawsoltes wieslawsoltes commented Jan 7, 2021

Optimizes performance and memory usage for Parse operations.

This PR has been split and summary moved to tracking issue #802

Split status:

@mrbean-bremen
Copy link
Member

@wieslawsoltes - just a suggestion: I would propose to split this PR into several PRs, e.g. get the current one working, let it review (I'm hoping for @inforithmics here) and merge it and go for the next bunch. This way reviewing will be easier, you have stable versions you can rely on, and there are less possible conflict with other changes.

@wieslawsoltes
Copy link
Contributor Author

@wieslawsoltes - just a suggestion: I would propose to split this PR into several PRs, e.g. get the current one working, let it review (I'm hoping for @inforithmics here) and merge it and go for the next bunch. This way reviewing will be easier, you have stable versions you can rely on, and there are less possible conflict with other changes.

That is good idea, I will try to finish the current work and continue the rest in another PRs.

@wieslawsoltes
Copy link
Contributor Author

Closing this as changes have been split into smaller PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants