Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Bump com.android.tools.build:gradle from 8.3.2 to 8.4.0 #393

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 4, 2024

Bumps com.android.tools.build:gradle from 8.3.2 to 8.4.0.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from svenjacobs as a code owner May 4, 2024 07:19
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels May 4, 2024
@svenjacobs
Copy link
Owner

svenjacobs commented May 5, 2024

This AGP version requires at least Gradle 8.6 but once I upgrade to Gradle 8.6 it complains that compileSdkVersion needs to be declared although compileSdk is already declared. Even if I declare it via compileSdkVersion = "android-34" the project doesn't compile and complains about missing packages.

This is really weird and I never had to declare compileSdkVersion in newer projects. Also I have projects where Gradle 8.6 just works fine. As of now I have no idea why it's not working for this specific project.

Also see here where this occurred previously.

@svenjacobs
Copy link
Owner

@dependabot rebase

Bumps com.android.tools.build:gradle from 8.3.2 to 8.4.0.

---
updated-dependencies:
- dependency-name: com.android.tools.build:gradle
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/gradle/com.android.tools.build-gradle-8.4.0 branch from ab8f9f3 to dabd60f Compare May 18, 2024 11:18
@svenjacobs
Copy link
Owner

For some reason directly upgrading to Gradle 8.7 luckily has fixed this 🤷🏼

@svenjacobs svenjacobs merged commit 1b77a70 into main May 18, 2024
1 check passed
@svenjacobs svenjacobs deleted the dependabot/gradle/com.android.tools.build-gradle-8.4.0 branch May 18, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant