Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YouTube time markings are removed #460

Closed
guerda opened this issue Sep 16, 2024 · 2 comments · Fixed by #461
Closed

YouTube time markings are removed #460

guerda opened this issue Sep 16, 2024 · 2 comments · Fixed by #461
Labels
bug Something isn't working

Comments

@guerda
Copy link
Contributor

guerda commented Sep 16, 2024 •
edited
Loading

If you clean a YouTube URL which contains a time mark (?t=), this time mark will be removed too.

Example: https://www.youtube.com/live/CK6pE4-8kCg?si=5Y1bV4klawydjKqM&t=17271 becomes https://www.youtube.com/live/CK6pE4-8kCg

It should become https://www.youtube.com/live/CK6pE4-8kCg?t=17271

It might be enough to add t to this list

RegexFactory.exceptParameter("(v|search_query|list)")
@svenjacobs
Copy link
Owner

svenjacobs commented Sep 16, 2024 •
edited
Loading

Hello Philip,

thanks for the bug report. Yes, adding t should be enough. Do you want to create a PR? 😄

@svenjacobs svenjacobs added the bug Something isn't working label Sep 16, 2024
@guerda
Copy link
Contributor Author

guerda commented Sep 16, 2024

Great, thanks for the confirmation.

I will do once I get to a "big screen" computer 😁

guerda added a commit to guerda/leon that referenced this issue Sep 16, 2024
@guerda
bug(youtube): keep time mark parameter
220a3c0 
The t parameter contains the timestamp to jump to in a video. It's not a tracking parameter but must be kept.

fixes svenjacobs#460
@guerda guerda mentioned this issue Sep 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Keep time mark parameter for YouTube URLs guerda/leon
2 participants
@guerda @svenjacobs