Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SelectBase has wrong ItemValue instances in markup after question converted to other type #834

Closed
tsv2013 opened this issue Jun 10, 2020 · 1 comment
Closed

SelectBase has wrong ItemValue instances in markup after question converted to other type #834

tsv2013 opened this issue Jun 10, 2020 · 1 comment
Labels
bug
Milestone
v1.7.11

Comments

@tsv2013
Copy link
Member

tsv2013 commented Jun 10, 2020

See https://surveyjs.answerdesk.io/ticket/details/t4331/item-content-is-lost-after-changing-the-question-type-and-inserting-an-additional-item for more details.

Steps to reproduce:
Add a new radougroup question
Convert it to checkbox
Edit item text via adorner

Result:
Check modified choice item in property grid - it still the same
Choices and visibleChoices are not the same
@tsv2013 tsv2013 added the bug label Jun 10, 2020
tsv2013 added a commit that referenced this issue Jun 10, 2020
@tsv2013
Work for #834 - SelectBase has wrong ItemValue instances in markup af…
7f08db7 
…ter question converted to other type
tsv2013 added a commit to surveyjs/survey-library that referenced this issue Jun 10, 2020
@tsv2013
Temporary changed test. Work for surveyjs/survey-creator#834 - Select…
15b35fd 
…Base has wrong ItemValue instances in markup after question converted to other type
@tsv2013
Copy link
Member Author

tsv2013 commented Jun 10, 2020

And this commit is related - surveyjs/survey-library@9247a55

andrewtelnov added a commit that referenced this issue Jun 10, 2020
@andrewtelnov
Fix: SelectBase has wrong ItemValue instances in markup after questio…
86e024f 
…n converted to other type #834
andrewtelnov added a commit to surveyjs/survey-library that referenced this issue Jun 10, 2020
@andrewtelnov
Rollback the fix: SelectBase has wrong ItemValue instances in markup …
fcabfb0 
…after question converted to other type, surveyjs/survey-creator#834
@andrewtelnov andrewtelnov added this to the v1.7.11 milestone Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v1.7.11
Development

No branches or pull requests
2 participants
@tsv2013 @andrewtelnov