Choice Inplace Editor allows a batch creating of more than the specified number of items (creator.maximumChoicesCount) (#6638)

* Choice Inplace Editor allows a batch creating of more than the specified number of items (`creator.maximumChoicesCount`)
Fixes #6617

* Update string-editor.ts

* Update string-editor.ts

* Choice Inplace Editor allows a batch creating of more than the specified number of items (`creator.maximumChoicesCount`)
Fixes #6617

---------

Co-authored-by: tsv2013 <tsv2013@noreply.github.com>

Author: tsv2013

packages/survey-creator-core/src/components/string-editor.ts

@@ -34,7 +34,9 @@ export abstract class StringItemsNavigatorBase {
 
     newItems.splice(startIndex, 1);
     itemsToAdd.forEach((item, offset) => {
-      newItems.splice(startIndex + offset, 0, createNewItem(item));
+      if (creator.maximumChoicesCount <= 0 || newItems.length < creator.maximumChoicesCount) {
+        newItems.splice(startIndex + offset, 0, createNewItem(item));
+      }
     });
     this.question[this.getItemsPropertyName(items)] = newItems;
   }
@@ -610,4 +612,4 @@ export class StringEditorViewModelBase extends Base {
       .append("svc-string-editor--multiline", !!this.locString.allowLineBreaks)
       .toString();
   }
-}
+}

packages/survey-creator-core/tests/string-editor.tests.ts

@@ -1050,3 +1050,26 @@ test("Test string editor inplaceEditForValues without Creator", (): any => {
   expect(otherItem.locText.text).toEqual("Other changed");
   expect(q0.otherText).toEqual("Other changed");
 });
+
+test("StringEditor multiline paste for selectbase questions should respect creator.maximumChoicesCount", (): any => {
+  const creator = new CreatorTester();
+  creator.maximumChoicesCount = 4;
+  creator.JSON = {
+    elements: [
+      { type: "radiogroup", name: "q1", choices: ["item1", "item2"] },
+    ]
+  };
+  const question = creator.survey.getQuestionByName("q1") as QuestionRadiogroupModel;
+  creator.selectElement(question);
+
+  const questionAdorner = new QuestionAdornerViewModel(
+    creator,
+    question,
+    <any>undefined
+  );
+  var connectorItem2 = StringEditorConnector.get(question.choices[0].locText);
+
+  connectorItem2.onTextChanging.fire(null, { value: "\na\nb\r\nc\nd\n" });
+  expect(question.choices.map(c => c.text)).toEqual(["a", "b", "c", "item2"]);
+  expect(question.choices.map(c => c.value)).toEqual(["item3", "item4", "item5", "item2"]);
+});