Change default value for logoPositionY (#6633)

* Change default value for logoPositionY fix after surveyjs/survey-library#9460

* Change default value for logoPositionY fix after surveyjs/survey-library#9460

* Change default value for logoPositionY fix after surveyjs/survey-library#9460

* Change default value for logoPositionY fix after surveyjs/survey-library#9460

---------

Co-authored-by: OlgaLarina <olga.larina.dev@gmail.com>

Author: OlgaLarina

packages/survey-creator-core/src/components/tabs/header-model.ts

@@ -119,7 +119,7 @@ function getDefaultDescriptionSetting(isAdvanced?: boolean) {
   return result;
 }
 
-function getHorizontalAlignment(questionName: string, defaultValue: string): IJsonPropertyInfo {
+function getHorizontalAlignment(questionName: string): IJsonPropertyInfo {
   return <IJsonPropertyInfo>{
     type: "buttongroup",
     name: questionName,
@@ -129,10 +129,10 @@ function getHorizontalAlignment(questionName: string, defaultValue: string): IJs
       { value: "center" },
       { value: "right", },
     ],
-    default: defaultValue,
+    defaultFunc: () => Serializer.getProperty("cover", questionName).defaultValue,
   };
 }
-function getVerticalAlignment(questionName: string, defaultValue: string): IJsonPropertyInfo {
+function getVerticalAlignment(questionName: string): IJsonPropertyInfo {
   return <IJsonPropertyInfo>{
     type: "buttongroup",
     name: questionName,
@@ -143,7 +143,7 @@ function getVerticalAlignment(questionName: string, defaultValue: string): IJson
       { value: "middle" },
       { value: "bottom" },
     ],
-    default: defaultValue,
+    defaultFunc: () => Serializer.getProperty("cover", questionName).defaultValue,
   };
 }
 
@@ -163,7 +163,7 @@ Serializer.addClass(
       type: "buttongroup",
       name: "logoPosition",
       visibleIf: (obj) => obj.headerView === "basic",
-      default: "left",
+      defaultFunc: () => Serializer.getProperty("survey", "logoPosition").defaultValue,
       choices: [
         { value: "left" },
         { value: "right" }
@@ -173,7 +173,7 @@ Serializer.addClass(
       type: "spinedit",
       name: "height",
       visibleIf: (obj) => obj.headerView === "advanced",
-      default: 0,
+      defaultFunc: () => Serializer.getProperty("cover", "height").defaultValue,
       onPropertyEditorUpdate: function (obj: any, editor: any) {
         if (!!editor) {
           editor.unit = "px";
@@ -185,7 +185,7 @@ Serializer.addClass(
       type: "spinedit",
       name: "mobileHeight",
       visibleIf: (obj) => obj.headerView === "advanced",
-      default: 0,
+      defaultFunc: () => Serializer.getProperty("cover", "mobileHeight").defaultValue,
       onPropertyEditorUpdate: function (obj: any, editor: any) {
         if (!!editor) {
           editor.unit = "px";
@@ -197,7 +197,7 @@ Serializer.addClass(
       type: "buttongroup",
       name: "inheritWidthFrom",
       visibleIf: (obj) => obj.headerView === "advanced",
-      default: "survey",
+      defaultFunc: () => Serializer.getProperty("cover", "inheritWidthFrom").defaultValue,
       choices: [
         { value: "survey" },
         { value: "container" }
@@ -207,7 +207,7 @@ Serializer.addClass(
       type: "spinedit",
       name: "textAreaWidth",
       visibleIf: (obj) => obj.headerView === "advanced",
-      default: 0,
+      defaultFunc: () => Serializer.getProperty("cover", "textAreaWidth").defaultValue,
       onPropertyEditorUpdate: function (obj: any, editor: any) {
         if (!!editor) {
           editor.unit = "px";
@@ -260,7 +260,7 @@ Serializer.addClass(
         { value: "contain" },
         { value: "tile" },
       ],
-      default: "cover",
+      defaultFunc: () => Serializer.getProperty("cover", "backgroundImageFit").defaultValue,
       visibleIf: (obj) => obj.headerView === "advanced",
       onPropertyEditorUpdate: function (obj: any, editor: any) {
         if (!!editor) {
@@ -272,7 +272,13 @@ Serializer.addClass(
       type: "spinedit",
       name: "backgroundImageOpacity",
       visibleIf: (obj) => obj.headerView === "advanced",
-      default: 100,
+      defaultFunc: () => {
+        const defaultValue = Serializer.getProperty("cover", "backgroundImageOpacity").defaultValue;
+        if(defaultValue !== undefined && defaultValue !== null) {
+          return defaultValue * 100;
+        }
+        return defaultValue;
+      },
       onPropertyEditorUpdate: function (obj: any, editor: any) {
         if (!!editor) {
           editor.unit = "%";
@@ -296,12 +302,12 @@ Serializer.addClass(
       }
     },
 
-    getHorizontalAlignment("logoPositionX", "left"),
-    getVerticalAlignment("logoPositionY", "bottom"),
-    getHorizontalAlignment("titlePositionX", "left"),
-    getVerticalAlignment("titlePositionY", "bottom"),
-    getHorizontalAlignment("descriptionPositionX", "left"),
-    getVerticalAlignment("descriptionPositionY", "bottom"),
+    getHorizontalAlignment("logoPositionX"),
+    getVerticalAlignment("logoPositionY"),
+    getHorizontalAlignment("titlePositionX"),
+    getVerticalAlignment("titlePositionY"),
+    getHorizontalAlignment("descriptionPositionX"),
+    getVerticalAlignment("descriptionPositionY"),
   ]);
 
 Serializer.addProperties("header", [

packages/survey-creator-core/tests/tabs/theme-model-property-grid.tests.ts

@@ -841,7 +841,7 @@ test("headerViewContainer init state", (): any => {
     "backgroundImageFit": "cover",
     "backgroundImageOpacity": 100,
     "logoPositionX": "left",
-    "logoPositionY": "bottom",
+    "logoPositionY": "top",
     "titlePositionX": "left",
     "titlePositionY": "bottom",
     "descriptionPositionX": "left",