Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore/frontend] use localized time string in status & poll info page #3821

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cdn0x12
Copy link
Contributor

@cdn0x12 cdn0x12 commented Feb 23, 2025

Description

If this is a code change, please include a summary of what you've coded, and link to the issue(s) it closes/implements.

If this is a documentation change, please briefly describe what you've changed and why.

This PR makes a workaround to display timestamps in the user's local timezone:

Precise timestamps (containing hours and minutes) now converted to user's local time using browser's toLocaleString(), while vague timestamps (e.g. "Dec, 2024") are unchanged

Currently, the timestampPrecise in the Template has been removed because there's no need to return the server's local time right now. However, the corresponding field in template.go is still retained because I'm not sure if we might need it elsewhere.

The time format that users actually use might differ from the originally defined format. For example, it might now display as 12/31/2024, 11:11:11 PM instead of Dec 31, 2024, 23:11. It seems that some browsers convert it to a format like 2024-06-06T00:33:54.427Z, so I'm explicitly specifying it to match the timestampPrecise format.

Other parts of the settings panel already use toLocalString, so I didn't make any changes there.

closes #3819

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have not leveraged AI to create the proposed changes.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@cdn0x12 cdn0x12 changed the title [feature/frontend] use localized time string in status & poll info page [chore/frontend] use localized time string in status & poll info page Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature/frontend] Display user's local time on the post's details page
1 participant