[496] Features: Push notification, Incoming Transaction, Websockets #1739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed to features-push-notification.wallet.z52da5wt.xyz, artifacts |
ifaouibadi
force-pushed
the
features/push-notification
branch
2 times, most recently
from
59d59af to
1da6eac
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ifaouibadi
force-pushed
the
features/push-notification
branch
4 times, most recently
from
25a4750 to
935e243
Compare
ifaouibadi
changed the title
ifaouibadi
requested review from
peronczyk,
pstachel,
CedrikNikita,
subhod-i and
konradodo
and removed request for
peronczyk and
pstachel
ifaouibadi
force-pushed
the
features/push-notification
branch
from
88e16c6 to
3ae242a
Compare
konradodo
reviewed
Jan 13, 2023
konradodo
reviewed
Jan 13, 2023
konradodo
reviewed
Jan 13, 2023
konradodo
reviewed
Jan 13, 2023
konradodo
reviewed
Jan 13, 2023
ifaouibadi
force-pushed
the
features/push-notification
branch
from
3ae242a to
80dc992
Compare
CedrikNikita
requested changes
Jan 13, 2023
konradodo
reviewed
Jan 13, 2023
ifaouibadi
force-pushed
the
features/push-notification
branch
from
95bed7a to
348336a
Compare
peronczyk
requested changes
Jun 14, 2023
| Transactions: 'Transactions', | ||
| MicroBlocks: 'MicroBlocks', | ||
| KeyBlocks: 'KeyBlocks', | ||
| Object: 'Object', |
There was a problem hiding this comment.
This is actually not an channel name. Also Object is already used in the IMiddlewareWebSocketSubscriptionMessage payload prop.
There was a problem hiding this comment.
it's a channel name :D https://github.com/aeternity/ae_mdw#publishing-message-format
used to subscribe for specific address
peronczyk
approved these changes
Jun 14, 2023
peronczyk
reviewed
Jun 14, 2023
ifaouibadi
force-pushed
the
features/push-notification
branch
from
778c9a3 to
0e8147e
Compare
peronczyk
reviewed
Jun 14, 2023
There was a problem hiding this comment.
Changes done in this file are not necessary as non of the files are using them.
ifaouibadi
force-pushed
the
features/push-notification
branch
5 times, most recently
from
67fa74c to
4fc59ad
Compare
ifaouibadi
force-pushed
the
features/push-notification
branch
from
4fc59ad to
579de4d
Compare
ifaouibadi
force-pushed
the
features/push-notification
branch
from
579de4d to
1ee3f64
Compare
subhod-i
requested changes
Jul 4, 2023
ifaouibadi
force-pushed
the
features/push-notification
branch
from
1ee3f64 to
d88705c
Compare
ifaouibadi
force-pushed
the
features/push-notification
branch
from
d88705c to
dab5e82
Compare
ifaouibadi
force-pushed
the
features/push-notification
branch
from
dab5e82 to
809cbc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.