Fix ssh #17
Merged
Fix ssh #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In accordance to golang/go#19767 we are having wildcard host to fix the issue. We will change to proper host verification in the future
mbyczkowski
reviewed
Oct 4, 2017
CHANGELOG.md
Outdated
| @@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/). | |||
| ### Removed | |||
|
|
|||
| ### Fixed | |||
| * Complies with bug introduces from https://github.com/golang/go/issues/19767 | |||
There was a problem hiding this comment.
Complies with ssh behavior change in ... maybe?
There was a problem hiding this comment.
Hmm. Yeah I agree. Will change
There was a problem hiding this comment.
Fixed here 132aa9b
| @@ -118,7 +118,8 @@ func (s *SSHHandler) dial() (*ssh.Client, net.Listener, error) { | |||
| Auth: []ssh.AuthMethod{ | |||
| ssh.Password(s.FlyToken), | |||
| }, | |||
| Timeout: sshConnTimeout, | |||
| Timeout: sshConnTimeout, | |||
| HostKeyCallback: ssh.InsecureIgnoreHostKey(), | |||
There was a problem hiding this comment.
that should do for now 👍
|
@mbyczkowski Back at ya! Should be ready to go |
mbyczkowski
approved these changes
Oct 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Is this in reference to an existing issue?
Yes, golang/go#19767
General
Update Changelog following the conventions laid out on Keep A Changelog
Update README with any necessary configuration snippets
Existing tests pass
Purpose