fix: allow for long lines in SQL migrations #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For really long lines, it is possible for the scanner to run out of buffer space, resulting in ```go scanner.Err() // bufio.Scanner: token too long ``` This error was not checked however, causing a silent failure which was supressed. This commit adds a check for `scanner.Err()` and properly propagates any non-nil values.
sweatybridge
changed the title
Pull Request Test Coverage Report for Build 3118377043
💛 - Coveralls |
For really long lines, it is possible for the scanner to run out of buffer space, resulting in ```go scanner.Err() // bufio.Scanner: token too long ``` Following [this](https://stackoverflow.com/a/39864391/1137077) suggestion from Stack Overflow, this commit implements a workaround where the maximum buffer capacity is increased from 64K to 256K. Testing against the SQL file with geodata from #470 showed that already 128K was enough to resolve that issue. 256K is double that and - as a wise man once said - "ought to be enough for anybody".
sweatybridge
approved these changes
Sep 24, 2022
|
🎉 This PR is included in version 1.4.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
When lines that are too long are encountered, the scanner in
internal/utils/parser/token.go#Splitfails, but the.Err()is not checked, causing the error to be suppressed and theinternal/utils/parser/token.go#Splitfunc to return partial data.See #470
What is the new behavior?
internal/utils/parser/token.go#Splitare propagated to the caller.internal/utils/parser/token.go#Split.