Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clerk tpa domain pattern works for non-production mode domains #3273

Merged
merged 3 commits into from
Mar 9, 2025
Merged

fix: clerk tpa domain pattern works for non-production mode domains #3273

merged 3 commits into from
Mar 9, 2025
+3 −2

Conversation

hf
Copy link
Contributor

@hf hf commented Mar 9, 2025

Missing + wasn't caught.

@hf hf requested a review from a team as a code owner March 9, 2025 14:20
@coveralls
Copy link

coveralls commented Mar 9, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13749438201

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 57.825%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/config/config.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
internal/debug/postgres.go 3 64.86%
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 13734645830: -0.02%
Covered Lines: 7844
Relevant Lines: 13565
💛 - Coveralls

@hf @sweatybridge
apply suggestion from @sweatybridge
f8f3c13 
Co-authored-by: Han Qiao <sweatybridge@gmail.com>
@hf hf merged commit fe35846 into develop Mar 9, 2025
10 checks passed
@hf hf deleted the hf/fix-clerk-domain-pattern branch March 9, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sweatybridge sweatybridge sweatybridge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hf @coveralls @sweatybridge